fix(DB/Spell): Link triggered Shattrath flask effects to flask aura and proper area. #20122
Conversation
heyitsbench
changed the title
Should be resolved, please test again when you are able. |
Tested and no, it doesn't resolve the issue. |
Did you start from a clean world database on the second test? |
Rorschach91
added
Tested
Oh.....my bad, it works. It can be reviewed. |
|
A minor bug has been observed: after the server restarts, if you are inside the corresponding instance and use Shattrath for the first time, it does not take effect immediately. However, if you leave and re-enter the instance, or if you remove the buff and use another one, it will then work. Subsequently, no matter whether you login or out server, or consume it inside or outside the instance, everything works as expected. Conclusion: After the server restarts, the first time inside the corresponding instance use this does not take effect. |
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
This fix further breaks Shattrath Flasks are not persisted when leaving mentioned zones #19786 as the effects will no longer be kept outside nor inside the instances.This has mostly been resolved, but unfortunately when first consuming the flask in the open world, the flask's effects are maintained until your area is updated.How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.